-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typing and drop support for EOL versions #22
base: master
Are you sure you want to change the base?
Conversation
My thoughts on the items with question marks:
|
I went ahead and made the README updates you called out! |
I personally love pre-commit(-ci), as it does both automatic and non-automatic things, requires no setup and also runs in CI. Simply adding something to the config file is enough to make it run; with GitHub Actions, you need to add specific things for each tool you want to run. GitHub actions is fine by me, just sharing my opinion as well. Lmk what you want, I'll try to set it up. Do you want to port the |
Moving from setup.py to pyproject.toml sounds like a good idea! |
@controversial What development status would you consider |
Seeing https://martin-thoma.com/software-development-stages/, I would say either production/stable or mature, maybe mature because it's pretty old, but it could also be production/stable as there are still a few (almost basic for this size) features missing (#13, #12 (or is that already implemented with the cache and context manager?) and #7) and it's really small. |
I think production/stable sounds right. |
Pip/setuptools is somehow adding both a |
Ah, seems like the build cache just needed to be cleared |
Hi @controversial, I'm revisiting this, and I'm wondering why |
Closes #21
Todo (in no particular order):
Database
,ListDatabase
,DictDatabase
,set_data
)py.typed
filepy.typed
to distribution (package_data
)pyupgrade
from __future__ import annotations
requires-python
# TODO
spathlib
andPath.open
pyproject.toml
/setup.cfg
camelCase
->snake_case
)staticmethod
s intoclassmethod
s where possiblesudo
from README.mdlivejson.Database
->livejson.File
)livejson.Database
(replace withlivejson.File
)@controversial, could you give your opinion on every "?"?