Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getters for tests and remove old constraints, time in tests #273

Merged
merged 5 commits into from
Aug 30, 2024
Merged

Use getters for tests and remove old constraints, time in tests #273

merged 5 commits into from
Aug 30, 2024

Conversation

ocots
Copy link
Member

@ocots ocots commented Aug 29, 2024

Related to #232 (comment)

@ocots ocots linked an issue Aug 29, 2024 that may be closed by this pull request
Update test_onepass.jl to replace field accesses by getters #272
Closed
@ocots ocots requested a review from jbcaillau August 29, 2024 21:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

Package name latest stable
CTDirect.jl
CTFlows.jl
OptimalControl.jl

@ocots ocots changed the title getters for tests and constraints, time Use getters for tests and remove old constraints, time in tests Aug 30, 2024
@ocots ocots marked this pull request as draft August 30, 2024 06:45
@ocots
Copy link
Member Author

ocots commented Aug 30, 2024

J'ai mis en draft car il y a des fail dans les packages. Il faut voir pourquoi.

@ocots
Copy link
Member Author

ocots commented Aug 30, 2024

C'est plutôt bien les breakage. Je m'en suis bien servi pour ne pas tout cassé :-)

@ocots ocots marked this pull request as ready for review August 30, 2024 08:13
@ocots
Copy link
Member Author

ocots commented Aug 30, 2024

@jbcaillau Tu peux jeter un oeil, merge puis merge dans ta branche si tu veux.

@jbcaillau
Copy link
Member

C'est plutôt bien les breakage. Je m'en suis bien servi pour ne pas tout cassé :-)

nice @ocots breakages in there (previously)?

IMG_3469

jbcaillau
jbcaillau reviewed Aug 30, 2024
View reviewed changes
test/test_model.jl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocots I see that you have also updated old calls, including time! 👍🏽

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and constraint!

jbcaillau
jbcaillau reviewed Aug 30, 2024
View reviewed changes
test/test_model.jl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocots ... and old constraint! 👍🏽👍🏽

@ocots
Copy link
Member Author

ocots commented Aug 30, 2024

C'est plutôt bien les breakage. Je m'en suis bien servi pour ne pas tout cassé :-)

nice @ocots breakages in there (previously)?

IMG_3469

Now they pass but there were some fails at first. The comment is updated at each new commit.

jbcaillau
jbcaillau reviewed Aug 30, 2024
View reviewed changes
test/test_onepass.jl
Copy link
Member

@jbcaillau jbcaillau Aug 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocots dynamics, constraints, mayer, lagrange, getters used (+ dimension getters): huge test update! 👍🏽👍🏽👍🏽

jbcaillau
jbcaillau approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@jbcaillau jbcaillau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job @ocots 🚀

@jbcaillau jbcaillau merged commit 468ae3b into main Aug 30, 2024
9 checks passed
@ocots ocots deleted the 272-update-test_onepassjl-to-replace-field-accesses-by-getters branch August 30, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbcaillau jbcaillau jbcaillau approved these changes

Assignees

@ocots ocots

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update test_onepass.jl to replace field accesses by getters
2 participants
@ocots @jbcaillau