Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to TerminalSessionManager everywhere and fix small bug #1698

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

Yaraslaut
Copy link
Member

  1. Avoid qml signal handling

  2. Handle action per key press without repeating, so you can not spawn new tabs when holding key-binding for it

@github-actions github-actions bot added the frontend Contour Terminal Emulator (GUI frontend) label Jan 2, 2025
@Yaraslaut Yaraslaut force-pushed the improvements/manager_usage branch from e4ab26e to 19fbe21 Compare January 2, 2025 21:18
@Yaraslaut Yaraslaut added the no changelog Tells the CI to not require a changelog entry label Jan 2, 2025
@Yaraslaut Yaraslaut force-pushed the improvements/manager_usage branch 2 times, most recently from 07f6fbd to 880bf94 Compare January 2, 2025 21:23
src/contour/TerminalSession.cpp Outdated Show resolved Hide resolved
src/contour/TerminalSession.cpp Outdated Show resolved Hide resolved
@Yaraslaut Yaraslaut force-pushed the improvements/manager_usage branch from 880bf94 to afed123 Compare January 2, 2025 21:40
@Yaraslaut Yaraslaut force-pushed the improvements/manager_usage branch from afed123 to f5e2a93 Compare January 2, 2025 21:41
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. thanks

@Yaraslaut Yaraslaut force-pushed the improvements/manager_usage branch 2 times, most recently from 995c751 to a3b6b0d Compare January 5, 2025 15:29
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you :)

@Yaraslaut Yaraslaut enabled auto-merge (rebase) January 6, 2025 09:02
@Yaraslaut Yaraslaut force-pushed the improvements/manager_usage branch from a3b6b0d to 154c204 Compare January 6, 2025 14:14
@Yaraslaut Yaraslaut force-pushed the improvements/manager_usage branch from 154c204 to bbb6a86 Compare January 6, 2025 14:14
@Yaraslaut Yaraslaut merged commit ca16c0e into master Jan 6, 2025
31 checks passed
@Yaraslaut Yaraslaut deleted the improvements/manager_usage branch January 6, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Contour Terminal Emulator (GUI frontend) no changelog Tells the CI to not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants