Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to Ubuntu 22.04 to fix Puppeteer #940

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Conversation

smaye81
Copy link
Member

@smaye81 smaye81 commented Oct 24, 2024

From Puppeteer docs:

Ubuntu 23.10+ (or possibly other Linux distros in the future) ship an AppArmor profile that applies to Chrome stable binaries installed at /opt/google/chrome/chrome (the default installation path). This policy is stored at /etc/apparmor.d/chrome. This AppArmor policy prevents Chrome for Testing binaries downloaded by Puppeteer from using user namespaces resulting in the No usable sandbox! error when trying to launch the browser

We are currently seeing this error in CI due to our usage of ubuntu-latest in our CI Github Action images. It seems that Puppeteer has disabled this check as part of puppeteer/puppeteer#13196, but it doesn't look like this has been released yet. Once it has, we could potentially update to that latest version of Puppeteer and reinstate usage of ubuntu-latest. In the meantime, though, this pins our CI image to ubuntu-22.04 to get CI to pass.

Copy link

github-actions bot commented Oct 24, 2024

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 24, 2024, 2:55 PM

Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
@smaye81 smaye81 force-pushed the sayers/pin_to_ubuntu_2204 branch from 181b6c0 to 1164263 Compare October 24, 2024 14:54
Signed-off-by: Steve Ayers <[email protected]>
@smaye81 smaye81 requested a review from jhump October 24, 2024 15:09
Copy link
Member

@jhump jhump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb!

@smaye81 smaye81 merged commit dba56d5 into main Oct 24, 2024
5 of 7 checks passed
@smaye81 smaye81 deleted the sayers/pin_to_ubuntu_2204 branch October 24, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants