Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPNEGO support #56

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add SPNEGO support #56

wants to merge 1 commit into from

Conversation

Tagar
Copy link

@Tagar Tagar commented May 28, 2019

As proposed in #55

Thank you.

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

As proposed in conda-forge#55 

Thank you.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ocefpaf
Copy link
Member

ocefpaf commented May 28, 2019

Can you add a test for that functionality?

@Tagar
Copy link
Author

Tagar commented May 28, 2019

@ocefpaf to test SPNEGO, I would need a spnego/kerberos-enabled web service to test that.. ideas if we have that available as part of CI?
Also, it's my first contribution here.. can you please send a pointer to some existing tests?
Thank you.

@ocefpaf
Copy link
Member

ocefpaf commented May 28, 2019

I was not thinking about an elaborated test like that 😄. Just a curl -V like you had in the issue and check for the appropriated string. It can be a command test in the recipe.

@jakirkham
Copy link
Member

Also this could use a build number bump 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants