Keep sessions around between each ConanRequester #17455
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid creating a new session for each ConanRequester instance, this helps a lot with performance, as it avoids the overhead duplicate handshakes
memsharded
reviewed
Dec 12, 2024
memsharded
reviewed
Dec 13, 2024
AbrilRBS
commented
Dec 19, 2024
AbrilRBS
commented
Dec 23, 2024
memsharded
reviewed
Dec 23, 2024
memsharded
approved these changes
Dec 23, 2024
franramirez688
approved these changes
Dec 27, 2024
memsharded
reviewed
Dec 27, 2024
| @@ -31,6 +32,8 @@ def __init__(self, conan_api): | |||
| self.conan_api = conan_api | |||
| self._home_folder = conan_api.home_folder | |||
| self._remotes_file = HomePaths(self._home_folder).remotes_path | |||
| # Wraps an http_requester to inject proxies, certs, etc | |||
| self._requester = ConanRequester(self.conan_api.config.global_conf, self.conan_api.cache_folder) | |||
There was a problem hiding this comment.
We need to design, implement and document properly the "invalidating" and reloading of global.conf, like the requester will not get new conf after a config install. I think this is perfectly good as default, but the "invalidation" should also be doable and documented. I'll create a ticket for this later.
| self._url_creds = _SourceURLCredentials(cache_folder) | ||
| self._max_retries = config.get("core.net.http:max_retries", default=2, check_type=int) |
There was a problem hiding this comment.
The _max_retries is now legacy?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Cache HTTP request sessions between API calls
Docs: TODO
Avoid creating a new session for each ConanRequester instance, this helps a lot with performance, as it avoids the overhead duplicate handshakes
I get an additional 40% speedup on top of #17449