[Feature] Added features to the premake cli wrapper #17398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modifiable premake action (autodetected in constructor) - Modifiable lua file location - Custom user actions (defined within the premake5.lua file) exposed as 'arguments'
memsharded
reviewed
Dec 15, 2024
There was a problem hiding this comment.
It would be great to add a couple of unit test illustrating the usage and functionality of these changes. I understand they cover some customization cases, which seems legit, but seeing the actual usage tests help to polish the UI and also to get them covered for the future to avoid possible future breakages.
Thanks for your contribution @Ohjurot !
|
Thanks for the feedback @memsharded! I will implement as soon as I have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature:
Addes features to the preamke5 cli wrapper:
premake5.luafile is changeableargumentsThees changes are required in order to fully support calling the premake5 executable. This lays the foundation for a
PremakeToolchain.This is one of the key components of #14724 but in a modified version. I plan to add the other main feature (build) as a follow up under
PremakeToolchain. As I have understand as long as premake does not have a build feature. Which it does not have. It should be "chained" as a Toolchain that would utilize the cli wrapper and the platform specific build system wrapper (MSBuildor a directmakecall) other than being integrated in the cli wrapper. Correct?Would we need to add any test coverage other than the "basic" test @memsharded added? Like checking that arguments work etc.)
Currently there is (as previously discussed) no documentation for the whole premake feature set. I assume we will stay like this for now. I would however recommend to document the feature as soon as premake is feature complete.
developbranch, documenting this one.