-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openscenegraph: allow building with other jpeg implementations, fix c++17 msvc build, bump deps #18783
Conversation
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit ab61b84openscenegraph/3.6.5
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
openscenegraph is not conan-v2-ready, but this is out of scope of this PR, ready for review |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@maksim-petukhov sorry about the radio silence on this one, as it's only a v1 compatible recipe we didn't circle back to this PR until now, thanks a lot for your patience |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 03aa872openscenegraph/3.6.5@#87f2fb86877d4c4e8cc939bfbdc94da3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This recipe is still not ported to Conan 2.x, so it will not pass by the CI. As you only want to fix some points, we still can merge it manually.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit f2e36c7openscenegraph/3.6.5@#0a6a9e7d7e1c3df5fe10c07565629b1d
|
@uilianries @RubenRBS it there anything else I can do to merge this PR? |
@uilianries @RubenRBS @jcar87 just a friendly ping |
@@ -16,3 +16,19 @@ patches: | |||
base_path: source_subfolder | |||
- patch_file: patches/0006-Declare-result-as-LONG-for-Mingw-build.patch | |||
base_path: source_subfolder | |||
- patch_file: patches/0007-fix-msvc-with-std-c++17.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add patch_description
for each one of these new patches.
# Conflicts: # recipes/openscenegraph/all/conandata.yml # recipes/openscenegraph/all/conanfile.py
Conan v1 pipeline ✔️All green in build 9 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Failure in build 9 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Hooks produced the following warnings for commit f2e36c7openscenegraph/3.6.5@#0a6a9e7d7e1c3df5fe10c07565629b1d
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Specify library name and version: openscenegraph/3.6.5
PR adds choices for jpeg implementation in
with_jpeg
option. It also fixes msvc build whencompiler.cppstd=17
is in profile by adding several patches:Commit for
0008-replace-mem-fun-ref.patch
is available in OpenSceneGraph repository onnew_master
branch: openscenegraph/OpenSceneGraph@8a0114aCommit for
0007-fix-msvc-with-std-c++17.patch
is available in OpenSceneGraph repository onmaster
branch openscenegraph/OpenSceneGraph@1b557a4 but new version is not released yet.0009-replace-auto-ptr-in-plugins.patch
and0010-replace-ptr-fun-in-obj-plugin.patch
patches are proposed upstream in this PR Allow building gdal, dae, ffmpeg and obj plugins with/std:c++17
msvc flag openscenegraph/OpenSceneGraph#1246