Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jellyseerr] Update nodejs if not up-to-date #1563

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

makstech
Copy link
Contributor

@makstech makstech commented Jan 18, 2025

✍️ Description

With older installation of Jellyseer, running update in LXC breaks the Jellyseerr, because Node was v20, and pnpm fails with

 ERR_PNPM_UNSUPPORTED_ENGINE  Unsupported environment (bad pnpm and/or Node.js version)

Your Node version is incompatible with "/opt/jellyseerr".

Expected version: ^22.0.0
Got: v20.18.0

So with this change, update script checks for current node version, and if it's not v22.x, it just updates the node source list to the same one that is in the install script, and then upgrades packages.

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)

🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)

@makstech makstech requested a review from a team as a code owner January 18, 2025 02:11
@github-actions github-actions bot added the update script A change that updates a script label Jan 18, 2025
@makstech makstech changed the title Jellyseerr update node [jellyseerr] Update nodejs if not up-to-date Jan 18, 2025
@MickLesk
Copy link
Member

We have already there for expect 40 Scripts. But i can merge. Its not an issue. Its an Feature :p

Looks nodejs_22 Branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants