ci: combine header checks into workflow with PR comment #1257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Description
This pull request include changes to the GitHub Actions workflows for validating shell scripts.
Consolidation of validation workflows:
.github/check-script.yml
: Removed the workflow that checked shell scripts for specific lines and executable permissions. This workflow was in the wrong folder and therefore never executed..github/workflows/check-metadata.yml
: Removed the workflow that checked metadata lines in shell scripts. This workflow uses the wrong paths and was therefore never executed.Introduction of a new validation workflow:
This pull request consolidates and improves the script validation workflows by combining multiple checks into a single comprehensive validation workflow. The changes remove redundant workflows and introduce a new workflow that performs various checks on shell scripts.
Consolidation of script validation workflows:
.github/workflows/validate-scripts.yml
: Added a new workflow that performs multiple checks on shell scripts, including:source
line.It might be good to note that a lot of files to not comply with the checks in this workflow. So any new PRs will fail and should be fixed before merging.
Like #1239 the comment placed by the workflow has start and end tags, to make it possible to add more information to a single comment from other workflows. In code it looks like:
Please remove unneeded lines!
🛠️ Type of Change
Please check the relevant options:
✅ Prerequisites
The following steps must be completed for the pull request to be considered:
📋 Additional Information (optional)
Tested in se-bastiaan#2