Avoid capturing onValue closure in useSubscription forever #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue similar to #purescript-elmish/83
The
useSubscription
hook was directly subscribing theonValue
callback to the subscription ininit
, thus capturing that particular instance ofonValue
forever, ignoring the fact thatonValue
may change from call to call.To fix, made it work similar to
useEffect
- sending an actual message from the subscription and callingonValue
fromupdate
.Added a test to check that it happens correctly. While I was at it, added a similar test for
useEffect
.