Check if trust zone is deployed in commands that exec into SPIRE server #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnctl
reviewed
Nov 29, 2024
Some cofidectl commands exec into the SPIRE server to query it using the spire-server CLI. This fails with an error if the SPIRE server has not yet been deployed. This change fixes the issue for the following commands: - federation list (reports Health as Inactive) - workload list (fails with a better error message) - workload discover (continues without querying SPIRE server) Fixes: #52
markgoddard
force-pushed
the
issues/52
branch
from
38b3c89 to
ae29fcb
Compare
jsnctl
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cofidectl commands exec into the SPIRE server to query it using the
spire-server CLI. This fails with an error if the SPIRE server has not
yet been deployed.
This change fixes the issue for the following commands:
Fixes: #52