Fall back to SPDY for exec if WebSockets aren't supported #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If using cofidectl with an older (pre 1.31.0) k8s cluster, it may fail to exec into the spire-server container. This is because websockets are behind a default false feature gate until 1.31.0, and unsupported before 1.29.0. This change fixes the issue using a fallback executor, adapted from the exec code in kubectl. It will try to use websockets, then fall back to SPDY if unavailable. Fixes: #120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using cofidectl with an older (pre 1.31.0) k8s cluster, it may fail
to exec into the spire-server container. This is because websockets are
behind a default false feature gate until 1.31.0, and unsupported before
1.29.0.
This change fixes the issue using a fallback executor, adapted from the
exec code in kubectl. It will try to use websockets, then fall back to
SPDY if unavailable.
Fixes: #3