Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Reason column to federation list output #118

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Adds Reason column to federation list output #118

merged 4 commits into from
Jan 7, 2025

Conversation

jsnctl
Copy link
Contributor

@jsnctl jsnctl commented Jan 4, 2025 •
edited
Loading

implements #50

  • Adds Reason column to cofidectl federation list output
  • Adds const strings for statuses and reasons
  • Adds integration test case for no bundle

@jsnctl jsnctl self-assigned this Jan 4, 2025
@jsnctl jsnctl added this to the release-0.9.0 milestone Jan 4, 2025
@jsnctl jsnctl requested a review from markgoddard January 6, 2025 09:30
@jsnctl
Copy link
Contributor Author

jsnctl commented Jan 7, 2025

Int test needed a re-run but seems happier now

@jsnctl jsnctl enabled auto-merge (squash) January 7, 2025 10:20
markgoddard
markgoddard requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, int test failed

@jsnctl jsnctl requested a review from markgoddard January 7, 2025 12:32
@jsnctl jsnctl merged commit fdbbed1 into main Jan 7, 2025
6 checks passed
@jsnctl jsnctl deleted the jsnctl/add-reason-to-federation-health-check branch January 7, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markgoddard markgoddard markgoddard approved these changes

@meyskens meyskens Awaiting requested review from meyskens

@mattbates mattbates Awaiting requested review from mattbates

@nialdaly nialdaly Awaiting requested review from nialdaly

Assignees

@jsnctl jsnctl

Labels
None yet
Projects
None yet
Milestone
release-0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jsnctl @markgoddard