Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junguksim
approved these changes
Jan 14, 2025
|
|
||
| const baseUrl = process.env.REACT_APP_API_URL; | ||
|
|
||
| const GetProducts = async ({ |
There was a problem hiding this comment.
슥 보고 컴포넌트인줄 알았는데 함수네요!
컴포넌트는 PascalCase, 함수는 camelCase 를 지켜주세요!
| @@ -0,0 +1,2 @@ | |||
| export * from "./useMediaQuery"; | |||
There was a problem hiding this comment.
별도의 파일을 만들지 말고, useMediaQuery.js 에서 export default 를 사용해보세요!
| const ProductBest = () => { | ||
| const [products, setProducts] = useState([]); | ||
| const media = hooks.useMediaQuery(""); | ||
| const initColumn = media === "pc" ? 4 : media === "tablet" ? 2 : 1; |
There was a problem hiding this comment.
initColumn 도 어차피 media 에 의해 정해지는 값이라면, useMediaQuery 커스텀 훅에서 같이 처리해서 리턴해도 좋을 것 같아요.
const {media, initColumn} = useMediaQuery()
이런식으로요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://seha-pandamarket-react.netlify.app/
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게