Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sprint2 [이동혁] sprint1+2
junguksim
approved these changes
Jan 14, 2025
| if(windowWidth < 865) return 'mobileBestItemList'; | ||
| } | ||
|
|
||
| useEffect(()=> { |
There was a problem hiding this comment.
이렇게 반복되는 것은 customHook 으로 모듈화할 수 있습니다!
한 번 찾아보고 적용해보시면 좋을 것 같아요 :)
| if(windowWidth < 865) setBestPageSize(1); | ||
| },[windowWidth]) | ||
|
|
||
| async function getBestProducts() { |
| const [bestPage,setBestPage] = useState(1); | ||
|
|
||
| function currentEnv() { | ||
| if(windowWidth >= 1200) return 'bestItemList'; |
There was a problem hiding this comment.
1200, 865,등의 값이 반복되므로, export + 변수 하나 설정해서 한번에 다 관리되도록 하면 더욱 좋겠네요.
PC_WIDTH, TABLET_WIDTH 이런 식으로요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
https://helpful-trifle-e965b6.netlify.app/