Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[가승연] sprint4 #63

Conversation

Syyga
Copy link
Collaborator

@Syyga Syyga commented Jan 3, 2025

No description provided.

@Syyga Syyga changed the title Basic 가승연 sprint4 가승연 sprint4 Jan 3, 2025
@Syyga Syyga changed the title 가승연 sprint4 [가승연] sprint4 Jan 3, 2025
@Syyga Syyga requested a review from junguksim January 3, 2025 09:01
Copy link
Collaborator

@junguksim junguksim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 짜주셨습니다! 변수나 함수 명명을 굉장히 잘하시네요 ㅎㅎ 보는데 거슬림이 없었습니다.

async await 연습을 해보시길 바래서 코멘트 하나 남겨뒀습니다.
비동기 함수간의 순서 보장은 실무에서도 굉장히 자주 발생하는 케이스이므로, 한번 연습해보시길 바랍니다!
callback 으로도, promise.then() 으로도, async await 로도 모두 해보시면 좋겠네요!

deleteProduct
} from "./ProductService.js";

// Articles 테스트
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게 써도 상관은 없는데요! async await 연습할 겸 한번 리팩토링 해보셨으면 좋겠습니다!

create 를 먼저 하고 -> getArticleList 를 했을 때 방금 생성한 데이터가 있는지 확인할 수 있도록 코드를 다시 짜보세요.
( 비동기 함수간의 의존성, 순서 보장을 연습해보시면 좋겠습니다.)

@junguksim junguksim merged commit 80c0241 into codeit-sprint-fullstack:basic-가승연 Jan 7, 2025
1 check passed
@junguksim
Copy link
Collaborator

추가로, .gitignore 통해서 node_modules 를 제외해주세요!

getArticleList(1, 20, "가승연").then(console.log);
getArticle(1392).then(console.log);
createArticle("syggaaa", "가승연이오", "하하하하하ㅏ하하하하").then(console.log);
patchArticle(1392, { title: "give me money" }).then(console.log);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

특히 여기서, 바로 위에서 생성한 article 을 업데이트 하는 걸 시도해보세요.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants