-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak stage 2 terminal instructions #2526
Conversation
WalkthroughThe pull request updates the instructional text within the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/components/course-page/course-stage-step/second-stage-tutorial-card.hbs (1)
Line range hint
47-51
: Consider removing or updating the hardcoded completion rateThe hardcoded 98% completion rate might be misleading if it's not regularly updated. Consider either:
- Removing it until the TODO is implemented
- Fetching real-time statistics from the backend
- Adding a note that this is an approximate figure
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/components/course-page/course-stage-step/second-stage-tutorial-card.hbs
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: test
🔇 Additional comments (1)
app/components/course-page/course-stage-step/second-stage-tutorial-card.hbs (1)
7-7
: Great improvement in instruction clarity!The updated text makes it explicitly clear that students should treat all commands as invalid at this stage. This aligns well with the visual example and tooltips below, creating a more cohesive learning experience.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files📢 Thoughts on this report? Let us know! |
Thanks 1Dedios for the suggestion! |
Checklist:
[percy]
in the message to trigger)Summary by CodeRabbit