Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End stage 2 experiment: Short Instructions vs Link to Code Examples #2517

Merged
merged 2 commits into from
Jan 6, 2025
Merged

End stage 2 experiment: Short Instructions vs Link to Code Examples #2517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f28dc3
feat: Remove feature flag for showing short instructions in second st…
andy1li Jan 6, 2025
00873ab
Merge branch 'main' into stage-2-experiments
andy1li Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/course-page/course-stage-step/second-stage-tutorial-card.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<CoursePage::InstructionsCard @title="How to pass this stage" id="second-stage-tutorial-card" ...attributes>
<:content>
<div class="prose dark:prose-invert mb-5">
{{#if (and this.shouldShowShortInstructions (eq @repository.course.slug "shell"))}}
{{#if (eq @repository.course.slug "shell")}}
<div class="mb-5 prose-compact">
{{markdown-to-html @courseStage.shortInstructionsMarkdown}}
</div>
Expand Down
4 changes: 0 additions & 4 deletions app/components/course-page/course-stage-step/second-stage-tutorial-card.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,6 @@ export default class SecondStageTutorialCardComponent extends Component<Signatur
);
}

get shouldShowShortInstructions() {
return this.featureFlags.canSeeShortInstructionsForStage2;
}

get steps() {
return [
new ImplementSolutionStep(this.args.repository, this.implementSolutionStepIsComplete),
Expand Down
4 changes: 0 additions & 4 deletions app/services/feature-flags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ export default class FeatureFlagsService extends Service {
return this.currentUser && (this.currentUser.isStaff || this.currentUser.isConceptAuthor);
}

get canSeeShortInstructionsForStage2() {
return this.currentUser?.isStaff || this.getFeatureFlagValue('can-see-short-instructions-for-stage-2') === 'test';
}

get currentUser() {
return this.authenticator.currentUser;
}
Expand Down