Merge pull request #2517 from codecrafters-io/stage-2-experiments

End stage 2 experiment: Short Instructions vs Link to Code Examples
codecrafters-io · Jan 6, 2025 · 382c0b6 · 382c0b6
2 parents 3a8b1d6 + 00873ab
commit 382c0b6
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 9 deletions.
diff --git a/app/components/course-page/course-stage-step/second-stage-tutorial-card.hbs b/app/components/course-page/course-stage-step/second-stage-tutorial-card.hbs
@@ -1,7 +1,7 @@
 <CoursePage::InstructionsCard @title="How to pass this stage" id="second-stage-tutorial-card" ...attributes>
   <:content>
     <div class="prose dark:prose-invert mb-5">
-      {{#if (and this.shouldShowShortInstructions (eq @repository.course.slug "shell"))}}
+      {{#if (eq @repository.course.slug "shell")}}
         <div class="mb-5 prose-compact">
           {{markdown-to-html @courseStage.shortInstructionsMarkdown}}
         </div>

diff --git a/app/components/course-page/course-stage-step/second-stage-tutorial-card.ts b/app/components/course-page/course-stage-step/second-stage-tutorial-card.ts
@@ -83,10 +83,6 @@ export default class SecondStageTutorialCardComponent extends Component<Signatur
     );
   }
 
-  get shouldShowShortInstructions() {
-    return this.featureFlags.canSeeShortInstructionsForStage2;
-  }
-
   get steps() {
     return [
       new ImplementSolutionStep(this.args.repository, this.implementSolutionStepIsComplete),

diff --git a/app/services/feature-flags.js b/app/services/feature-flags.js
@@ -14,10 +14,6 @@ export default class FeatureFlagsService extends Service {
     return this.currentUser && (this.currentUser.isStaff || this.currentUser.isConceptAuthor);
   }
 
-  get canSeeShortInstructionsForStage2() {
-    return this.currentUser?.isStaff || this.getFeatureFlagValue('can-see-short-instructions-for-stage-2') === 'test';
-  }
-
   get currentUser() {
     return this.authenticator.currentUser;
   }