Updating the Makefile script on the website to work natively with MacOS. #1417
Conversation
✅ Deploy Preview for tag-security ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Pedro Ignacio <[email protected]>
pedroignacio13
force-pushed
the
PedroIgnacio-Makefile-correction
branch
from
a13f233 to
da862fe
Compare
|
I am not sure if this is run in CI as well. If so, wouldn't it have an impact as the "new" sed instruction would always run? I am wondering if there would be a better way of running the script for MacOS vs Linux (e.g. with a flag or something like that) |
|
I'll let this PR open and try to find alternatives to this. |
There was a problem hiding this comment.
I agree with @mrcdb - this doesn't work with linux (and the expected CI) processes natively.
Until such a time where this workflow is refactored - we may want to consider a conditional for macos/linux OR requiring gnu-sed on macos development environments.
| @@ -14,14 +14,15 @@ deps: | |||
|
|
|||
| # Update all imported markdown files to work as standalone hugo pages (except READMEs, see below) | |||
| # sed command is configured for the Netlify ubuntu env | |||
| # If you're NOT running this on a mac, you'll need to remove the empty string after -i (line 25) | |||
There was a problem hiding this comment.
| # If you're NOT running this on a mac, you'll need to remove the empty string after -i (line 25) | |
| # If you're running this on a mac, you'll need to add double quotes after -i in the sed command below: `sed -i "" "1s/^/$$text_to_prepend/" "$$file"; \` |
| find root -type f -name '*.md' | while IFS= read -r file; do \ | ||
| base_name=$$(basename "$$file" .md); \ | ||
| if [ "$$file" = "/_index.md" -o "$$base_name" = "README" ]; then \ | ||
| continue; \ | ||
| fi; \ | ||
| title_case=$$(echo "$$base_name" | sed -e 's/-/ /g' -e 's/\b\(.\)/\u\1/g' | sed 's/cncf/CNCF/Ig'); \ | ||
| text_to_prepend="---\ntitle: \"$$title_case\"\n---\n"; \ | ||
| sed -i "1s/^/$$text_to_prepend/" "$$file"; \ | ||
| sed -i "" "1s/^/$$text_to_prepend/" "$$file"; \ |
There was a problem hiding this comment.
| sed -i "" "1s/^/$$text_to_prepend/" "$$file"; \ | |
| sed -i "1s/^/$$text_to_prepend/" "$$file"; \ |
After having some issues setting up the environment locally on MacOS, we figured it out what the problem was.
This PR adapts the Makefile script to work correctly when setting up the environment for local development.
Thanks Brandt and Eddie for the help on this issue!