Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Astro experimental template #7394

Closed
wants to merge 2 commits into from

Conversation

alexanderniebuhr
Copy link
Contributor

In theory this should be the only change needed after withastro/adapters#406 lands, not sure if c3 needs any other changes though 🤔


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because:

@alexanderniebuhr alexanderniebuhr requested review from a team as code owners November 30, 2024 08:17
Copy link

changeset-bot bot commented Nov 30, 2024

⚠️ No Changeset found

Latest commit: a8f1f4c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 3, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12136748058/npm-package-wrangler-7394

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7394/npm-package-wrangler-7394

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12136748058/npm-package-wrangler-7394 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12136748058/npm-package-create-cloudflare-7394 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12136748058/npm-package-cloudflare-kv-asset-handler-7394
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12136748058/npm-package-miniflare-7394
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12136748058/npm-package-cloudflare-pages-shared-7394
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12136748058/npm-package-cloudflare-vitest-pool-workers-7394
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12136748058/npm-package-cloudflare-workers-editor-shared-7394
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12136748058/npm-package-cloudflare-workers-shared-7394
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12136748058/npm-package-cloudflare-workflows-shared-7394

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@emily-shen emily-shen added the blocked Blocked on other work label Dec 9, 2024
@alexanderniebuhr
Copy link
Contributor Author

Since there is an option to ignore files now, I think we will stick with that for now. Until Worker Assets is out of Beta, and we know if Pages will stay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked on other work
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants