Merge pull request #88 from clappr/feature/avoid-exceptions-pre-play

Avoid exceptions due to undefined shakaPlayer
clappr · Dec 1, 2020 · 095c3dc · 095c3dc
2 parents d6a3ee0 + 8ec74a1
commit 095c3dc
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/clappr-dash-shaka-playback.js b/src/clappr-dash-shaka-playback.js
@@ -37,6 +37,8 @@ class DashShakaPlayback extends HTML5Video {
   }
 
   get seekRange() {
+    if (!this.shakaPlayerInstance) return { start: 0, end: 0}
+
     return this.shakaPlayerInstance.seekRange()
   }
 
@@ -75,6 +77,8 @@ class DashShakaPlayback extends HTML5Video {
   }
 
   getCurrentTime() {
+    if (!this.shakaPlayerInstance) return 0
+
     return this.shakaPlayerInstance.getMediaElement().currentTime - this.seekRange.start
   }
 
@@ -83,6 +87,8 @@ class DashShakaPlayback extends HTML5Video {
   }
 
   get presentationTimeline() {
+    if (!this.shakaPlayerInstance) return
+
     return this.shakaPlayerInstance.getManifest().presentationTimeline
   }
 
@@ -101,6 +107,8 @@ class DashShakaPlayback extends HTML5Video {
   }
 
   getProgramDateTime() {
+    if (!this.shakaPlayerInstance) return 0
+
     return new Date((this.presentationTimeline.getPresentationStartTime() + this.seekRange.start) * 1000)
   }