Various fixes and improvements #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Use a prefix for the temp folders. 2) When starting the node, wait for the RPC to be ready. Results if faster start of the script. 3) When terminating the node, wait of the process to finish (kills it after a timeout). Results in faster termination of the script.
When running the latest bitcoin 0.20.0, the script crashes when "Creating output with 0 BTC" because the node rejects the "dust" transaction. Here we remove the relay fee and fix the issue.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements:
Fix crash in latest bitcoind:
When running the latest bitcoin 0.20.0, the script
crashes when "Creating output with 0 BTC" because
the node rejects the "dust" transaction.
Fix travis tests