Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update the react native tutorial for v8 #778

Merged

Conversation

dannyhw
Copy link
Contributor

@dannyhw dannyhw commented Sep 23, 2024

This pr updates the en react native tutorial to v8, since the api is the same there aren't that many changes required and most the changes are updating images to match the redesigned ui

these changes go together with this pr here:
chromaui/intro-storybook-react-native-template#5

@jonniebigodes
Copy link
Collaborator

@dannyhw thanks for taking the time to put together this pull request and update the tutorial's version. I was about to message you as I saw the updates to the tutorial, but you beat me to it 🙂. If you're ok with it, I'll take a look at it tomorrow morning my time, and if nothing stands out we can merge both at the same time and get everything published. Sounds good to you?

Looking forward to hearing from you.

Have a great day.

Stay safe

@dannyhw
Copy link
Contributor Author

dannyhw commented Sep 23, 2024

Hey, tomorrow is great :). However let's hold off on releasing it as im still working on the release post for v8 and need to get an idea of the content schedule.

Thanks for jumping on it so quick.

Copy link
Collaborator

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dannyhw I just left a small item for you to look into when you can. Nothing significant. Let me know once you've addressed it so we can coordinate to publish the updated version.

Have a great day.

Stay safe

@dannyhw
Copy link
Contributor Author

dannyhw commented Oct 4, 2024

Hey @jonniebigodes, I've released the new version so I think we're good to merge this.

@jonniebigodes
Copy link
Collaborator

Sure thing @dannyhw , I'll get this one merged in. I saw the notification drop-in. Thanks once again for taking the time to update the tutorial. Appreciate it 🙏.

Have a great weekend.

Stay safe

@jonniebigodes jonniebigodes merged commit 95c21ec into chromaui:master Oct 4, 2024
1 check failed
@dannyhw
Copy link
Contributor Author

dannyhw commented Oct 4, 2024

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants