-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi language and framework support #28
Conversation
@domyen how are we going to deal with the intersection between languages and frameworks? e.g. we aren't going to have Spanish text for the Vue code. I don't know if the translators are going to be keen to do multiple versions. Perhaps the chooser should be more lang+framework at the same time:
|
Additionally, what do we want the URLs to look like? Do we want to special case the React/English URLs (so say learnstorybook.com/get-started goes to React/English) or fully qualify everything (so it'd be learnstorybook.com/react/english/get-started), or both? |
Also we have a few strings littered through the UI, should we translate them too?
|
A little dodgy and there a still quite a few unanswered questions.
@domyen did a first pass at this just to remind myself of how Gatsby works and think about potential solutions. Let's resolve the questions above and I can do it for real. |
URL strawman
Localization of UI Picker UI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, if you need help i'm in!
0666939
to
6f2d786
Compare
@domyen take a look at this now. I think it's pretty close to done (for React en/es). Let me know what I missed. It's not the cleanest ever but it works. I'd like to do a pass over it and get linting working and clean up a bit once we are satisfied with the functionality. |
This looks great! Todo
Once this is done, I think we're all clear to merge and ship it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just fix the twitter part and be synchronized with the github repo that is being shown in english.
@icarlossz do you mean the twitter message "I'm learning Storybook..."? And great catch re:github "edit on GitHub" link! |
Yep @domyen |
Are we planning on translating the internal language (e.g. the tweet?). Otherwise I think this is good to go, let's merge and we can make any fixes on |
Going to merge this! Hope I didn't mess up the spanish @icarlossz |
* ✍️ Update: Design Systems For Developers > Introduction 번역 교정 * Update: Architecture revise * Update: Build revise * Update: Review revise * Update: Review revise2
This PR encapsulates the work necessary to support multiple languages and frameworks.
Todo
Header.js