-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR template standardized #201
base: main
Are you sure you want to change the base?
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☑️☑️ 👍🏻
.github/PULL_REQUEST_TEMPLATE.md
Outdated
<!-- ignore-task-list-start --> | ||
|
||
<!-- | ||
## Release checklist | ||
- [ ] [Changeset](https://github.com/chromaui/chromatic-e2e/blob/main/DEVELOPMENT.md#pr-workflow-with-changesets) created in this PR | ||
|
||
--> | ||
|
||
<!-- ignore-task-list-end --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually want this ignored? When would we not create a Changeset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! I'll have it commented-in with a note to remove if not publishing to NPM.
- id: task-completed | ||
uses: chromaui/task-completed-checker-action@main | ||
with: | ||
repo-token: '${{ secrets.GITHUB_TOKEN }}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to add this secret!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's created for me: https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication
With recent changes to the Chromatic issue template, this PR brings this repo's PR template up to the same formatting. Minor differences occur where we need to be repo-specific or have different deploy steps.
What Changed
The PR issue template includes checkboxes for QA and an optional release checklist