Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR template standardized #201

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

PR template standardized #201

wants to merge 9 commits into from

Conversation

skitterm
Copy link
Member

@skitterm skitterm commented Sep 25, 2024

With recent changes to the Chromatic issue template, this PR brings this repo's PR template up to the same formatting. Minor differences occur where we need to be repo-specific or have different deploy steps.

What Changed

The PR issue template includes checkboxes for QA and an optional release checklist

Copy link

codacy-production bot commented Sep 25, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (81fa588) 294 280 95.24%
Head commit (6f92554) 294 (+0) 280 (+0) 95.24% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#201) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@skitterm skitterm marked this pull request as ready for review September 25, 2024 22:00
@skitterm skitterm changed the title PR template standardized with changes to Chromatic PR template PR template standardized Sep 25, 2024
Copy link
Contributor

@andrewortwein andrewortwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☑️☑️ 👍🏻

Comment on lines 27 to 35
<!-- ignore-task-list-start -->

<!--
## Release checklist
- [ ] [Changeset](https://github.com/chromaui/chromatic-e2e/blob/main/DEVELOPMENT.md#pr-workflow-with-changesets) created in this PR

-->

<!-- ignore-task-list-end -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually want this ignored? When would we not create a Changeset?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I'll have it commented-in with a note to remove if not publishing to NPM.

- id: task-completed
uses: chromaui/task-completed-checker-action@main
with:
repo-token: '${{ secrets.GITHUB_TOKEN }}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add this secret!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skitterm skitterm requested a review from thafryer September 27, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants