-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --no-swap flag #193
base: master
Are you sure you want to change the base?
add --no-swap flag #193
Conversation
bfd3d53
to
ca55e8c
Compare
As a heads up I'll be putting this on the back burner until after the v0.8.0 release. I'm focusing on getting existing functionality fixed up while saving new features for later |
LGTM |
(Just a random user's opinion, don't take this with authority) I think taking the naming from sed would make this more easily discoverable, and is more easily understandable IMO: -i[SUFFIX], --in-place[=SUFFIX]
edit files in place (makes backup if SUFFIX supplied) I'm not a fan of |
b8dca6b
to
38d42d4
Compare
38d42d4
to
73c91a5
Compare
Merged latest master & reworked the implementation accordingly (which made it a good bit simpler 👍 ) |
as per suggestion chmln#193 (comment)
@ThinkChaos thanks, I took (part of) your suggestion, and renamed to |
See #191 for details
I gave it a shot. Tell me what you think :)
I've also parameterized the tests so the flag is also tested for the same cases.
I did some hyperfine benchmarks to make sure performance isn't severely degraded and it's mostly the same:
(tried with input sizes: 10B, 1KB, 10MB and containing
foo
on each line)