Vtr testing radar extractor comparison update #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ElliotP-K
commented
Dec 17, 2024
•
ElliotP-K
commented
- Updated Boreas config files
- New detector parameters
- Threshold values for ICP failure conditions (see extractor comparison VTR3 Update)
- New additions to the config files so they work with code from the VTR3 Gyro update
- See main update for general testing: https://github.com/utiasASRL/radar_topometric_localization/pull/1
added 4 commits
September 3, 2024 11:36
ElliotP-K
force-pushed
the
vtr_testing_radar_extractor_comp
branch
from
ec6cd28 to
5af5b51
Compare
ElliotP-K
force-pushed
the
vtr_testing_radar_extractor_comp
branch
from
5af5b51 to
93b220c
Compare
lisusdaniil
reviewed
Jan 10, 2025
| @@ -129,6 +134,21 @@ def main(dataset_dir, result_dir, velocity): | |||
| writer = csv.writer(file, delimiter=' ') | |||
| writer.writerows(result) | |||
| print("Written to file:", osp.join(output_dir, odo_input + ".txt")) | |||
|
|
|||
There was a problem hiding this comment.
This is already implemented in the latest branch! Please remove the duplicate
lisusdaniil
requested changes
Jan 10, 2025
lisusdaniil
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.