Chore(feature)/add request and session logs #532 #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
leoseg
force-pushed
the
chore(feature)/addRequestAndSessionLogs-#532
branch
from
83d4e5d to
e380a9f
Compare
|
Hi i did E2E testing with cypress all test run trough except the reset password tests as the mail doesn't arrive at Mailslurp, manual password reset with my Protonmail works without a problem (also done over the password reset button) , do I have to set a specific setting for the Mailslurp? There was another test that failed which was in the inital-exploration test because it expected the "Healing from sexual trauma" to be displayed in the "welcome/bumble" page which was not there (but still is available for the user under courses manually checked it with a bumble user). I think this could be more of a Frontend issue. What do you think @kyleecodes ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #532
What changes did you make and why did you make them?
Implemented Cls for request-id logging (request id generated by uuid4) and session logging. For session logging a hash is generated from the firebase user id and the login time which should be unique and also coupling the session id to firebase.
Did you run tests? Share screenshot of results:
Run tests with npm run tests -> All passed .
How did you find us? (GitHub, Google search, social media, etc.):
GitHub