Fix hiccup-like rendering of boolean attrs #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter attributes with `val` instead of `second`, to be more concise and performant.
|
Thinking and testing needed: impact on existing apps? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering elements, such as checkboxes, drop-down options, or other inputs, Hiccup will simply omit attributes that are false or nil.
The current state of
htmlrenders these attributes likechecked="false"which leads to browsers interpreting it as actually being checked.This commit updates the
htmlfunction to be more compatible with Hiccup, and allows you to use Hiccup'shiccup.formnamespace with Enlive.