Fix several language selection issues #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have added a commit to prevent initializing the locale if Cemu has no UI translation for the default language, which should fix #580. |
Exzap
reviewed
Oct 16, 2023
Thank you very much. The actual testing did indeed fix the issue of using the default local language for macOS, and both the switching were effective |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the logic for loading UI translations, which should fix several issues people have encountered.
First, we now translate UI strings using the wxTranslations class directly: this makes language selection work with languages that aren't installed/supported on the operating system (this mostly applies to Linux: before this PR, choosing a language not installed on the machine didn't do anything).
Furthermore, the logic used to apply the UI localization has been fixed so that when the "Default" language is selected, the UI uses the system default language (and not English as it did before). The "English" language option now also works as intended: it stays selected upon closing and reopening the settings window and when it's selected, no localization is applied.
While I was at it, I also took the opportunity to format the "last played" date in the game list using the currently selected locale.
Some testing on macOS would be appreciated.
Fixes #717
Fixes #616
Should fix #580