Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set version for macOS bundle #1431

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Set version for macOS bundle #1431

merged 1 commit into from
Dec 2, 2024

Conversation

neebyA
Copy link
Contributor

@neebyA neebyA commented Nov 26, 2024

On macOS, the version of Cemu is always reported as 2.0.0, regardless of the version of the actual release. For example, this what the app version is reported as despite being from the 2.4 pre-release:

grep -A 1 'CFBundleVersion' /Applications/Cemu.app/Contents/Info.plist
    <key>CFBundleVersion</key>
    <string>2.0.0</string>

This is due to cmake using the variable CMAKE_PROJECT_VERSION to set the version of the app bundle, rather than the values of the environment variables passed to the GitHub workflow.

This PR sets the version for the macOS app bundle using the workflow environment variable, instead of the hardcoded CMAKE_PROJECT_VERSION of 2.0.0.

@Exzap Exzap merged commit eca7374 into cemu-project:main Dec 2, 2024
5 checks passed
@Exzap
Copy link
Member

Exzap commented Dec 2, 2024

thanks!

@neebyA neebyA deleted the mac-version branch December 2, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants