Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Url to JavascriptBindingEventArgs #5021

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amaitland
Copy link
Member

@amaitland amaitland commented Jan 2, 2025

Issue #5001

Summary:

  • Add additional info to event args

Changes:

  • Add url to event args

How Has This Been Tested?
Tests have been updated

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Updated documentation

Checklist:

  • Tested the code(if applicable)
  • Commented my code
  • Changed the documentation(if applicable)
  • New files have a license disclaimer
  • The formatting is consistent with the project (project supports .editorconfig)

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@amaitland amaitland force-pushed the enhancement/addurltoJavascriptBindingEventArgs branch from acda14f to 0cb2878 Compare January 2, 2025 23:05
@amaitland amaitland changed the title Add Url to JavascriptBinding event args and allow for custom method runner queue Add Url to JavascriptBinding event args Jan 2, 2025
@amaitland
Copy link
Member Author

I had originally though about exposing the JS repository and method runner queue for users to customise, reverted this change as I'm not sure that it's wise.

@amaitland amaitland changed the title Add Url to JavascriptBinding event args Add Url to JavascriptBindingEventArgs Jan 2, 2025
@amaitland amaitland marked this pull request as ready for review January 2, 2025 23:13
@AppVeyorBot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants