Changes snake cased fields to camel casing #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cherry pick from #206 |
afrittoli
reviewed
May 13, 2024
There was a problem hiding this comment.
Thanks @xibz - this looks mostly good to me.
I think it would be good to merge it after #220 which introduces schema validation and enables CI on branches, so that we get better testing for this one.
The other bit is that we don't usually start -draft releases for patch releases. The normal process is that we just bump the patch version by one.
However, since we have a few PRs to merge for the next v0.4.x release, my proposal would be that we don't change the spec version in any of the PRs.
Once everything we need is merged I'll make a PR that updates the spec version to v0.4.1 (see my comments in #220).
Merged
This commit improves consistency in our spec and examples by having all keys be camel cased. This made 4 changes: chain_id -> chainId context_id -> contextId link_kind -> linkKind link_type -> linkType Signed-off-by: xibz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves consistency in our spec and examples by having all
keys be camel cased.
This made 4 changes:
chain_id -> chainId
context_id -> contextId
link_kind -> linkKind
link_type -> linkType
Signed-off-by: xibz [email protected]