-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define every url
and viewUrl
field as format uri
#200
Conversation
Thanks @davidB - we discussed this topic during the last CDEvents WG and we plan to include it in the next milestone v0.5. We'll try to have most of the breaking changes in one milestone (v0.5). Once the v0.4 release is out (this week), this PR will have to be rebased and the version of the affected events updated. |
0e9f1b7
to
410359a
Compare
@afrittoli The PR is rebased on main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should rename URL
to URI
s
Signed-off-by: David Bernard <[email protected]>
Signed-off-by: David Bernard <[email protected]>
a2c758d
to
cc5754a
Compare
@xibz I renamed every field named |
@xibz / @afrittoli Can you merge the PR (I'm not allowed). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @davidB - the change looks good.
Since all event versions have been bumped already and are currently in -draft
this looks fine, no further updates required.
Changes
url
andviewUrl
withformat: "uri"
as proposed in type ofurl
fields is inconsistent into jsonschema #191-draft
, I didn't update themSubmitter Checklist
As the author of this PR, please check off the items in this checklist: