-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add outcome to buildfinished event #179
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,9 +20,9 @@ | |
"type": { | ||
"type": "string", | ||
"enum": [ | ||
"dev.cdevents.build.finished.0.1.1" | ||
"dev.cdevents.build.finished.0.1.2-draft" | ||
], | ||
"default": "dev.cdevents.build.finished.0.1.1" | ||
"default": "dev.cdevents.build.finished.0.1.2-draft" | ||
}, | ||
"timestamp": { | ||
"type": "string", | ||
|
@@ -62,6 +62,15 @@ | |
"properties": { | ||
"artifactId": { | ||
"type": "string" | ||
}, | ||
"outcome": { | ||
"type": "string", | ||
"minLength": 1, | ||
"enum": [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The biggest difference here between There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Absolutely! And that is also stated for the taskRun.finished and pipelineRun.finished in their md doc (core.md). The json schemas for those events lack those enum definitions, and there is an issue to fix that - #159 . I believe the outcome enums for the build.finished event should have similar values as the enum for the outcomes of taskRun.finished and pipelineRun.finished. |
||
"succeeded", | ||
"failed", | ||
"cancelled" | ||
] | ||
} | ||
}, | ||
"additionalProperties": false, | ||
|
@@ -97,4 +106,4 @@ | |
"context", | ||
"subject" | ||
] | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,7 +67,13 @@ | |
"type": "string" | ||
}, | ||
"outcome": { | ||
"type": "string" | ||
"type": "string", | ||
"minLength": 1, | ||
"enum": [ | ||
"passed", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These enums don't match the core.md doc on pipelineRun.finished. Same for taskRun.finished. |
||
"failed", | ||
"cancelled" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We might want to describe the meaning of values in the enum, to help consistency in adoption. |
||
] | ||
}, | ||
"errors": { | ||
"type": "string" | ||
|
@@ -106,4 +112,4 @@ | |
"context", | ||
"subject" | ||
] | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-draft
is needed here too