-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit test ci job #3 #12
Conversation
@rjtch I prefer to have as few as possible workflow files (eg 1
I also try to limit as much as possible setup that could not be reproduced by the developer locally (=> why I prefer mise or devcontainer over using a tool that configures toolchain on for ci like Creating concurrent jobs (with matrix) as done for lint and tests (in this PR) looks friendly in terms of visual report and execution time (in parallel). But I prefer sequential with fewer jobs because:
I'm sure in conventional commit we should use prefix |
|
reminder: |
Signed-off-by: rjtch <[email protected]>
Signed-off-by: rjtch <[email protected]>
8bfd992
to
ab3f106
Compare
Signed-off-by: rjtch <[email protected]>
- name: install mise until mise-action is allowed | ||
uses: taiki-e/install-action@v2 | ||
with: | ||
tool: mise, cargo-nextest, cargo-hack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let me know which action you need exactly and I will add it to the configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The action is already added taiki-e/install-action@v2 you has added it in my last pr. This action helps downloading tools necessary for the flow. They are used in the Makefile.
Thanks for all the updates! |
added pipeline for tests