Configurable diff to decide when a frame is orange #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Chrome on Ubuntu and Mac OS X recording a video in 60fps using ffmpeg it sometimes happens that the first frame after the full orange frame is partly orange (half or 1/4 orange etc). This only happens for me with Chrome. See #20. VisualMetrics then picks up that partly orange frame as the first visual change. The current default config only makes the difference between a full orange and white. Making it configurable makes it possible to have a higher limit when you run Chrome.
|
No, that will only solve some cases, have examples where it doesn't help. Let aim for a solution that fix every case. |
|
Removing the cropping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Chrome on Ubuntu and Mac OS X recording a video in 60fps using ffmpeg
it sometimes happens that the first frame after the full orange frame is
partly orange (half or 1/4 orange etc). This only happens for me with Chrome.
See #20. VisualMetrics then picks up that partly orange frame as the first
visual change.
The current default config only makes the difference between a full orange and
white. Making it configurable makes it possible to have a higher limit when you
run Chrome.
I got a bunch of example videos when this happens if need them Pat? It would be nicer to have a solution that fix the problem permanently but this at least makes it possible to have different configs that avoids picking up a too early visual change on Chrome.