Use array for default users

[blueyed]

This also avoids shelling out to whoami always, and only uses $USER
by default.

[carnager]

hmmm, Maybe instead of checking for old config we should update config instead?
Something like this:

readarray oldusers < <(grep default_user .config/rofi-pass/config)
default_users=(${a[@]##*=})
sed '/default_user/d' .config/rofi-pass/config
echo "default_users=(${array[@]})" > foo2

[blueyed]

Maybe instead of checking for old config we should update config instead?

Might not be as easy, e.g. you have to ignore comments etc. - not sure if you do this in the 2nd line already (?!).

[blueyed]

It is only barely tested btw, so please review with caution.

[carnager]

[carnager@caprica ~]$ grep default_user .config/rofi-pass/config 
[email protected]
default_user2=rasi
#default_user3=carnager
[carnager@caprica ~]$ readarray oldusers < <(grep -P '^default_user|^default_user2' .config/rofi-pass/config)
[carnager@caprica ~]$ default_users=(${oldusers[@]##*=})
[carnager@caprica ~]$ echo "default_users=(${default_users[@]})"
default_users=([email protected] rasi)

Updating seems to work fine. Now have to test if this works in general

What I like about this aproach that one can have as many users as he/she likes.

[blueyed]

Your approach would cause an extra grep run - while the config has been sourced already.
You also do not keep the order and/or respect the system config.

[carnager]

@blueyed Do you think you can update this to latest master? Working through these old PRs and this is one I am interested to test and eventually merge.

[blueyed]

@carnager
Done.
Not tested, and not much fun due to the spaces to tab changes.

[blueyed]

Rebased again (no conflicts).