-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LoongArch aliases and CS_OPT_SYNTAX_NO_DOLLAR support #2594
Conversation
Looks like also the alias mapping was missing. now it should be correct. Before the patch suggested
after applying the patch from @Rot127
After adding mapping of the aliases.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the suggestions, ten we are good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you.
Your checklist for this pull request
Detailed description
For some reasons the
CS_OPT_DETAIL_REAL
andCS_OPT_SYNTAX_NO_DOLLAR
were not supported in LoongArch, so it was impossible to get real info also from aliases.