data/udev/rules.d/66-snapd-autoimport.rules: remove udev snapd auto-import rule #14912
+0
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit relates to LP#1966203, which reported the presence of syslog errors associated with snapd auto-import that were not representative of a functional issue on Ubuntu Desktop or Server. A summary of the root cause is that systemd introduced a SystemCallFilter to units/systemd-udevd.service.in in commit ee8f26180d which restricted the syscalls available to udev. However snapd's 66-snapd-autoimport.rules attempts to import snap assertions from connected block devices, which conflicts with the filter. As per comment #6 in the LP bug, the snapd team determined that this udev rules file should not be triggered on desktop or server because the functionality is intended only for Ubuntu Core. This commit removes the rule as outlined in comment canonical#13 in the LP bug, which expressed intent to remove it from the snapd deb. Related Bugs: LP#1966203, LP#1971955
Meulengracht
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14912 +/- ##
==========================================
+ Coverage 78.20% 78.27% +0.06%
==========================================
Files 1151 1156 +5
Lines 151396 153396 +2000
==========================================
+ Hits 118402 120066 +1664
- Misses 25662 25929 +267
- Partials 7332 7401 +69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thu Jan 23 07:54:23 UTC 2025 Failures:Preparing:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit relates to LP#1966203, which reported the presence of syslog errors associated with snapd auto-import that were not representative of a functional issue on Ubuntu Desktop or Server.
A summary of the root cause is that systemd introduced a SystemCallFilter to units/systemd-udevd.service.in in commit ee8f261 which restricted the syscalls available to udev. However snapd's 66-snapd-autoimport.rules attempts to import snap assertions from connected block devices, which conflicts with the filter.
As per comment #6 in the LP bug, the snapd team determined that this udev rules file should not be triggered on desktop or server because the functionality is intended only for Ubuntu Core. This commit removes the rule as outlined in comment #13 in the LP bug, which expressed intent to remove it from the snapd deb.
Related Bugs: LP#1966203, LP#1971955
Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?