-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
daemon: fetch validation sets before checking refresh candidates #14907
base: master
Are you sure you want to change the base?
Conversation
`snap refresh --list` didn't report snaps that would be refreshed with a `snap refresh` because it, unlike the latter, didn't refresh validation sets which could make new snap revisions available. This change fetches new validation sets (without tracking them) before checking for refreshable snaps. Signed-off-by: Miguel Pires <[email protected]>
@pedronis this PR adds a side-effect to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Signed-off-by: Miguel Pires <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14907 +/- ##
==========================================
+ Coverage 78.20% 78.22% +0.02%
==========================================
Files 1151 1158 +7
Lines 151396 152944 +1548
==========================================
+ Hits 118402 119645 +1243
- Misses 25662 25912 +250
- Partials 7332 7387 +55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Failures:
|
snap refresh --list
didn't report snaps that would be refreshed with asnap refresh
because it, unlike the actual refresh, didn't refresh the validation sets which could make new snap revisions available. This change fetches new validation sets (without tracking them) before checking for refreshable snaps