Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces/seccomp: added new at-variant syscalls to base template #14902

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

maykathm
Copy link
Contributor

@maykathm maykathm commented Jan 7, 2025

No description provided.

@maykathm maykathm added the Needs security review Can only be merged once security gave a :+1: label Jan 7, 2025
@maykathm maykathm requested review from alexmurray and zyga January 7, 2025 09:15
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.24%. Comparing base (24a0034) to head (fa438f3).
Report is 89 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14902      +/-   ##
==========================================
+ Coverage   78.20%   78.24%   +0.03%     
==========================================
  Files        1151     1150       -1     
  Lines      151396   152777    +1381     
==========================================
+ Hits       118402   119538    +1136     
- Misses      25662    25857     +195     
- Partials     7332     7382      +50     
Flag Coverage Δ
unittests 78.24% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Copy link
Contributor

@alexmurray alexmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@ernestl
Copy link
Collaborator

ernestl commented Jan 8, 2025

Failures:

Cross distro tests needs attention, failures do not relate to changes.

@ernestl ernestl self-requested a review January 8, 2025 06:55
Copy link
Collaborator

@ernestl ernestl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ernestl ernestl merged commit fbbcc99 into canonical:master Jan 8, 2025
53 of 59 checks passed
@maykathm maykathm deleted the add-new-syscalls branch January 8, 2025 08:27
@ernestl ernestl added this to the 2.67.1 milestone Jan 14, 2025
@ernestl ernestl mentioned this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs security review Can only be merged once security gave a :+1:
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants