o/devicestate: remodeling with components #14878
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Needs Documentation -auto-
andrewphelpsj
force-pushed
the
remodel-components
branch
2 times, most recently
from
14d07dc to
804f0d8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14878 +/- ##
==========================================
- Coverage 78.20% 78.00% -0.21%
==========================================
Files 1151 1131 -20
Lines 151396 151712 +316
==========================================
- Hits 118402 118344 -58
- Misses 25662 26059 +397
+ Partials 7332 7309 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrewphelpsj
added
the
Run nested
andrewphelpsj
force-pushed
the
remodel-components
branch
2 times, most recently
from
22c77ca to
db63e57
Compare
…take in a type that can wrap local snaps and components
… contains components
…r in preparation for components The refactor makes it so all of the decisions about what to do for a snap in the incoming model are all in the same place. I feel that this is pretty useful now, and it will simplify adding the logic that is needed for handling components as well.
…mponent-setup when installing a snap with components This indicates to ifacestate's setup-profiles handler that the setup-profiles should operate on a snap and a set of components, rather than a single component.
…g a remodel, rather than snap IDs
andrewphelpsj
force-pushed
the
remodel-components
branch
from
db63e57 to
5fda097
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drafting for now just to run some spread tests.