-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lint): increase line-length max value #219
chore(lint): increase line-length max value #219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is dangerous.
You are opening the doors for contributors to start writing huge lines, including in places where such shouldn't happen (like contents
).
This seems to be driven by a problem in a mutation script in #142 . For that, I'd rather:
- just fix the mutation script. I get that it is a copy&paste, but if that copy&paste is "broken" that's not an excuse for us to accept it like that.
- if the issue however is that the YAML format is forcing an indentation that is causing that copy&paste to be longer than acceptable, then let's just increase the
max
value
- if the issue however is that the YAML format is forcing an indentation that is causing that copy&paste to be longer than acceptable, then let's just increase the
- another option is fiddling with the yamllint configuration. I'm not sure if it is possible, but ideally, we could be permissive about some blocks of yaml. E.g. you could allow the "level: warning", but only for the "mutation" blocks. Again, not sure if that's possible
- or, don't lint
#
comments
- or, don't lint
I think the issue in my PR is that the linter does not account for the indentation made before the contents itself. The length of the contents itself does not exceed the 80 characters. |
That's good to hear, as it makes me more confident about simply increasing the |
The maximum length of a line is now 100.
Updated the PR. Set the limit to 100 to account for any indentation spaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The maximum length of a line is now 100.
The maximum length of a line is now 100.
The maximum length of a line is now 100.
line-length
errors are now warnings.This PR increases the maximum length of a line in the yaml files.
Relevant discussions at #142.