Skip to content

Commit

Permalink
chore: apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Rafid Bin Mostofa <[email protected]>
  • Loading branch information
cjdcordeiro and rebornplusplus authored Jul 24, 2024
1 parent b4f8d28 commit f5836b9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ that apply. -->

* [ ] I have read the [contributing guidelines](
https://github.com/canonical/chisel-releases/blob/main/CONTRIBUTING.md)
* [ ] I have tested my changes
* [ ] I have tested my changes ([see how](https://github.com/canonical/chisel-releases/blob/main/CONTRIBUTING.md#7-test-your-slices-before-opening-a-pr))
* [ ] I have already submitted the [CLA form](
https://ubuntu.com/legal/contributors/agreement)

Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ conflicts between slice definitions files;
Apart from asserting your slice definitions' formatting, you must also test them
before opening a Pull Request.

Every Chisel release support the functional testing for slices via
Every Chisel release supports the functional testing for slices via
[Spread](https://github.com/snapcore/spread).

**We expect tests to be provided for every slice**, so please ensure you include
Expand Down

0 comments on commit f5836b9

Please sign in to comment.