chore: Routing form submitted but no booking - Salesforce actions #18387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeauyeung
commented
Dec 27, 2024
| @@ -23,6 +23,10 @@ export default function RoutingNavBar({ | |||
| target: "_blank", | |||
| href: `${appUrl}/reporting/${form?.id}`, | |||
| }, | |||
| { | |||
| name: "Incomplete Booking", | |||
There was a problem hiding this comment.
I'm open to changing this tab name
There was a problem hiding this comment.
There's a lot of Salesforce specific logic on this page. I would like to abstract this into it's own component but that can be in a follow up as this needs to go out.
The biggest challenge I see is linking up the save button in the SingleForm component.
| import { routingFormIncompleteBookingDataSchema as salesforceRoutingFormIncompleteBookingDataSchema } from "@calcom/app-store/salesforce/zod"; | ||
| import { IncompleteBookingActionType } from "@calcom/prisma/enums"; | ||
|
|
||
| const incompleteBookingActionDataSchemas: Record<IncompleteBookingActionType, z.ZodType<any>> = { |
There was a problem hiding this comment.
The incomplete booking action contains a data field. We're using Zod to validate
| @@ -1260,4 +1261,60 @@ export default class SalesforceCRMService implements CRM { | |||
| const response = await checkIfFreeEmailDomain(attendeeEmail); | |||
| return response; | |||
| } | |||
|
|
|||
| async incompleteBookingWriteToRecord( | |||
There was a problem hiding this comment.
We're reusing methods when writing to records.
dosubot
bot
added
crm-apps
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/31/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (12/31/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an "Incomplete booking" tab to the routing form page
Adds config to write to a Salesforce record when the "From filled, booking not created" event is triggered
Fixes #XXXX (GitHub issue number)
Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?