Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Info lost when navigating without warning routing form #18386

Merged

Conversation

Amit91848
Copy link
Contributor

What does this PR do?

Recording.2024-12-27.195017.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 27, 2024
@graphite-app graphite-app bot requested a review from a team December 27, 2024 14:27
Copy link

vercel bot commented Dec 27, 2024

@Amit91848 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input labels Dec 27, 2024
@dosubot dosubot bot added routing-forms area: routing forms, routing, forms ✨ feature New feature or request labels Dec 27, 2024
Copy link

graphite-app bot commented Dec 27, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/27/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/27/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/27/24)

1 label was added to this PR based on Keith Williams's automation.

@Praashh Praashh self-assigned this Dec 27, 2024
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working fine, LGTM!!

@Praashh Praashh self-requested a review December 27, 2024 18:13
Copy link
Contributor

github-actions bot commented Dec 27, 2024

E2E results are ready!

@Praashh
Copy link
Contributor

Praashh commented Jan 2, 2025

@Amit91848 can you please resolve merge conflicts ?

Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments for changes.

@Amit91848 Amit91848 requested a review from Praashh January 4, 2025 16:26
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thank you @Amit91848 🙏 .

@PeerRich PeerRich merged commit 455572b into calcom:main Jan 6, 2025
33 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Created by Linear-GitHub Sync ✨ feature New feature or request Low priority Created by Linear-GitHub Sync ready-for-e2e routing-forms area: routing forms, routing, forms ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-4596] Info lost when navigating without warning
4 participants