Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add refund policies for payment apps (Stripe, PayPal, etc.) #16858 #18372

Closed
wants to merge 2 commits into from

Conversation

Gyan-max
Copy link

/claim #16858
What does this PR do?
Fixes #16858
Adds refund policies for payment apps (Stripe, PayPal, etc.) to the Cal.com platform.
Implements logic to handle refunds appropriately based on various scenarios, such as failed bookings or cancellations.
Updated documentation and user interface to reflect the newly added policies.
Mandatory Tasks (DO NOT REMOVE)
I have self-reviewed the code to ensure it meets the project’s standards.
I have updated the documentation in /docs to include the changes made for refund policies.
Automated tests are included to verify the effectiveness of the changes made.
How should this be tested?
Environment Variables: Ensure the payment gateway credentials for Stripe and PayPal are set in the environment variables.
Minimal Test Data:
Create a booking using Stripe or PayPal.
Cancel the booking to trigger a refund process.
Expected Behavior:
Refund should process successfully, and the user should receive a confirmation.
Relevant logs should show refund status.
Checklist
I have read the contributing guide.
My code follows the style guidelines of this project.
I have added comments in the code, particularly for critical logic.
I have ensured that the changes do not generate any new warnings.

Copy link

vercel bot commented Dec 26, 2024

@Gyan-max is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 26, 2024
@graphite-app graphite-app bot requested review from a team December 26, 2024 08:00
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "/claim #16858". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions github-actions bot added billing area: billing, stripe, payments, paypal, get paid Low priority Created by Linear-GitHub Sync payments Created by Linear-GitHub Sync ✨ feature New feature or request 💎 Bounty A bounty on Algora.io ❗️ .env changes contains changes to env variables labels Dec 26, 2024
Copy link

graphite-app bot commented Dec 26, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/26/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/26/24)

1 label was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (12/26/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@Gyan-max Gyan-max changed the title /claim #16858 feat: Add refund policies for payment apps (Stripe, PayPal, etc.) #16858 Dec 26, 2024
@Praashh Praashh self-assigned this Dec 26, 2024
@anikdhabal
Copy link
Contributor

@Gyan-max thanks for you pr, but i don't think it is complete and an intuitive solution. Also it doesn't match out code style

@anikdhabal anikdhabal closed this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
billing area: billing, stripe, payments, paypal, get paid 🙋 Bounty claim 💎 Bounty A bounty on Algora.io community Created by Linear-GitHub Sync ❗️ .env changes contains changes to env variables ✨ feature New feature or request Low priority Created by Linear-GitHub Sync payments Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-4425] refund policies for payment apps (stripe, paypal, etc.)
4 participants